Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Stream stdlib tests to use the shared Testing framework and reorganizes how they’re loaded/executed in the stdlib test suite.
Changes:
- Replaced the old
stdlib0007_Stream.framassertions-based test file with a newtest/stdlib/Stream.framusingtestSuite/testCase. - Updated
test/stdlib/TestAll.framto import the Stream test module.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/stdlib/stdlib0007_Stream.fram | Removed legacy Stream tests written as standalone assert expressions. |
| test/stdlib/TestAll.fram | Adds an import for the Stream test module (affects which tests run in the aggregated session). |
| test/stdlib/Stream.fram | New Stream test module using the Testing framework (testSuite/testCase). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/stdlib/Stream.fram
Outdated
Comment on lines
88
to
94
| (Stream.foldRight1Err {~onError = fn _ => 42} | ||
| (fn (x : Int) y => x + y) (Stream.fromList [1, 2, 3, 4])) | ||
| 10); | ||
|
|
||
| testCase "empty" (fn _ => | ||
| assertEq | ||
| (Stream.foldRight1Err {~onError = fn _ => 42} |
There was a problem hiding this comment.
Inside the foldRight1Err suite, let ~onError () = 42 in is introduced but the subsequent calls still pass an explicit {~onError = fn _ => 42}. This makes the local ~onError binding unused and duplicates the same handler literal. Either remove the local ~onError binding, or use it in the foldRight1Err calls for consistency.
Suggested change
| (Stream.foldRight1Err {~onError = fn _ => 42} | |
| (fn (x : Int) y => x + y) (Stream.fromList [1, 2, 3, 4])) | |
| 10); | |
| testCase "empty" (fn _ => | |
| assertEq | |
| (Stream.foldRight1Err {~onError = fn _ => 42} | |
| (Stream.foldRight1Err {~onError} | |
| (fn (x : Int) y => x + y) (Stream.fromList [1, 2, 3, 4])) | |
| 10); | |
| testCase "empty" (fn _ => | |
| assertEq | |
| (Stream.foldRight1Err {~onError} |
ppolesiuk
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.